Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nvFuser setup with PyTorch 23.11 and later #9837

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

athitten
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Jul 22, 2024
@athitten
Copy link
Collaborator Author

@ericharper , @thomasdhc confirmed that this PR does not overlap with #9776, so we should be good.

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit be21e95 into r2.0.0rc1 Jul 24, 2024
225 of 332 checks passed
@ericharper ericharper deleted the athitten/disable_nvfuser branch July 24, 2024 19:20
github-actions bot pushed a commit that referenced this pull request Jul 24, 2024
* Disable nvFuser setup with PyTorch 23.11 and later

Signed-off-by: Abhishree <[email protected]>

* Apply isort and black reformatting

Signed-off-by: athitten <[email protected]>

---------

Signed-off-by: Abhishree <[email protected]>
Signed-off-by: athitten <[email protected]>
Co-authored-by: athitten <[email protected]>
athitten added a commit that referenced this pull request Aug 17, 2024
* Disable nvFuser setup with PyTorch 23.11 and later



* Apply isort and black reformatting



---------

Signed-off-by: Abhishree <[email protected]>
Signed-off-by: athitten <[email protected]>
Co-authored-by: Abhishree Thittenamane <[email protected]>
Co-authored-by: athitten <[email protected]>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Aug 19, 2024
…DIA#9870)

* Disable nvFuser setup with PyTorch 23.11 and later



* Apply isort and black reformatting



---------

Signed-off-by: Abhishree <[email protected]>
Signed-off-by: athitten <[email protected]>
Co-authored-by: Abhishree Thittenamane <[email protected]>
Co-authored-by: athitten <[email protected]>
Dido0o0 pushed a commit to Dido0o0/NeMo that referenced this pull request Aug 23, 2024
…DIA#9870)

* Disable nvFuser setup with PyTorch 23.11 and later



* Apply isort and black reformatting



---------

Signed-off-by: Abhishree <[email protected]>
Signed-off-by: athitten <[email protected]>
Co-authored-by: Abhishree Thittenamane <[email protected]>
Co-authored-by: athitten <[email protected]>
adityavavre pushed a commit to adityavavre/NeMo that referenced this pull request Sep 15, 2024
…DIA#9870)

* Disable nvFuser setup with PyTorch 23.11 and later

* Apply isort and black reformatting

---------

Signed-off-by: Abhishree <[email protected]>
Signed-off-by: athitten <[email protected]>
Co-authored-by: Abhishree Thittenamane <[email protected]>
Co-authored-by: athitten <[email protected]>
Signed-off-by: adityavavre <[email protected]>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
* Disable nvFuser setup with PyTorch 23.11 and later



* Apply isort and black reformatting



---------

Signed-off-by: Abhishree <[email protected]>
Signed-off-by: athitten <[email protected]>
Co-authored-by: Abhishree Thittenamane <[email protected]>
Co-authored-by: athitten <[email protected]>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
…DIA#9870)

* Disable nvFuser setup with PyTorch 23.11 and later



* Apply isort and black reformatting



---------

Signed-off-by: Abhishree <[email protected]>
Signed-off-by: athitten <[email protected]>
Co-authored-by: Abhishree Thittenamane <[email protected]>
Co-authored-by: athitten <[email protected]>
Signed-off-by: Hainan Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants